feat: implement secret filed & copy feature #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkrajniak
requested changes
Nov 10, 2025
projects/wc/src/app/components/generic-ui/detail-view/detail-view.component.html
Show resolved
Hide resolved
projects/wc/src/app/components/generic-ui/value-cell/secret-value/secret-value.component.ts
Show resolved
Hide resolved
projects/wc/src/app/components/generic-ui/value-cell/value-cell.component.html
Outdated
Show resolved
Hide resolved
projects/wc/src/app/components/generic-ui/value-cell/value-cell.component.ts
Show resolved
Hide resolved
projects/wc/src/app/components/generic-ui/value-cell/value-cell.component.ts
Show resolved
Hide resolved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
gkrajniak
requested changes
Nov 10, 2025
docs/readme-generic-ui.md
Outdated
| { | ||
| "label": "Type", | ||
| "property": "spec.type", | ||
| "labelDisplay": { |
Collaborator
There was a problem hiding this comment.
the labelDisplay shows up in the example not undert the proper object
gkrajniak
approved these changes
Nov 10, 2025
gkrajniak
requested changes
Nov 10, 2025
projects/wc/src/app/components/generic-ui/value-cell/secret-value/secret-value.component.scss
Outdated
Show resolved
Hide resolved
gkrajniak
requested changes
Nov 10, 2025
| <span class="secret-value"> | ||
| <span class="masked">{{ maskedValue() }}</span> | ||
| <span class="original">{{ value() }}</span> | ||
| <span class="value-text"> |
Collaborator
There was a problem hiding this comment.
do we need the span in span and I don't see the value-text class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.